KeithNava

Results 8 comments of KeithNava

LG-12069 Deactivate profile if a user never visits the Post Office

Thanks everyone for the thoughtful and thorough review! 🙏

feat: updated translations for DOS IPP

> Can you add the Chinese translations for the changes in this PR as well? @mitchellhenke we did plan on doing the Chinese translations in a separate ticket.

feat: updated translations for DOS IPP

**Spanish Translations** ![how_to_verify_DOS_es_translation_5_20_24](https://github.com/18F/identity-idp/assets/134446588/184fc584-2009-4404-b9b2-9caa09c08a5e) **French Translations** ![how_to_verify_DOS_fr_translation_5_20_24](https://github.com/18F/identity-idp/assets/134446588/d578a67d-6cd2-41ac-a5bf-86e78877dee0) **Simplified Chinese Translations** ![how_to_verify_DOS_simplified_chinese_translation_5_20_24](https://github.com/18F/identity-idp/assets/134446588/64243a0f-51b5-40a7-be0a-db39ddaa5d4e) @rutvigupta-design

feat: updated translations for DOS IPP

@rutvigupta-design Thanks for the review - looks like I had a bad merge conflict. Here's the updated screenshot for the Spanish translations. ![how_to_verify_DOS_es_translation_5_20_24_2](https://github.com/18F/identity-idp/assets/134446588/0d2f9885-99fb-4f6a-a8ad-3c7fee963482)

feat: updated translations for DOS IPP

@mitchellhenke @gina-yamada I think the merge is awaiting your approval. Thanks!

feat: updated translations for DOS IPP

@rutvigupta-design @gina-yamada Latest screenshots are below **Spanish Translations** ![how_to_verify_DOS_es_translation_5_21_24](https://github.com/18F/identity-idp/assets/134446588/3313b7e8-9cd0-4980-b94c-e423ad6ad87f) **French Translations** ![how_to_verify_DOS_fr_translation_5_21_24](https://github.com/18F/identity-idp/assets/134446588/b21c1978-d550-4be3-9a79-ec6d08259d65) **Simplified Chinese Translations** ![how_to_verify_DOS_simplified_chinese_translation_5_21_24](https://github.com/18F/identity-idp/assets/134446588/d9f998f2-a990-4315-aa81-edbbd27ac173)

feat: LG13235 consume eipp data from sinatra

Thanks so much everyone! I learned a lot during this review, really appreciated all the feedback! 💯

LG-13006: remove instances of skip_doc_auth

> Everything looks good to me. Nice Job! I just had one quick question. > > Does `skip_doc_auth` need to be removed from the `VALID_SESSION_ATTRIBUTES` constant in `app/services/idv/session.rb`? > >...