KarinG

Results 81 comments of KarinG

@pradpnayak - are you able to add some comments here re: having tested this PR? Have your team had it in production? It's not a trivial change and involves and...

@jitendrapurohit - could you please resolve the conflict. I updated the hook_number but there are more conflicts. Also -> has Fuzion had this in production?

@adixon @pradpnayak @shaneonabike @MegaphoneJon - you have all shown interest in this PR at some point. I sponsored this PR as I it resolves a structural conflict, but since none...

Thank you @bsilvern - I just kicked off the tests one more time and on pass will merge.

One of the fails is Stripe - re-running tests.

Hi @MegaphoneJon - that looks like a real failure: ``` 5) Drupal\Tests\webform_civicrm\FunctionalJavascript\ContributionDummyTest::testAssignContributionSecondContactSelectByUserPaymentProcessor Behat\Mink\Exception\ElementTextException: The text "10.00" was not found in the text of the element matching css "#wf-crm-billing-total". ```

Hi Jon -> if I understand your questions correctly -> yes we support non Functional JS tests ->

It really needs to pass the existing battery of tests before we can merge this.