webform_civicrm
webform_civicrm copied to clipboard
colemanw
D9 - Replace group usage with crmgroup to avoid inconsistency with drupal #group
Overview
Existing Contact can have validation error when filtered by group
Before
Existing Contact can have validation error when filtered by group
After
No error.
Technical Details
Implements the longer approach from https://github.com/colemanw/webform_civicrm/pull/619#issue-1013204079
Replace group usage with crmgroup to avoid inconsistency with drupal #group
Comments
Drupal Ticket: https://www.drupal.org/project/webform_civicrm/issues/3254254
@pradpnayak - are you able to add some comments here re: having tested this PR? Have your team had it in production? It's not a trivial change and involves and update hook.
@jitendrapurohit - could you please resolve the conflict. I updated the hook_number but there are more conflicts. Also -> has Fuzion had this in production?
@adixon @pradpnayak @shaneonabike @MegaphoneJon - you have all shown interest in this PR at some point. I sponsored this PR as I it resolves a structural conflict, but since none of our Semper IT clients nor any of the Fuzion clients are actively using it, it could really use some real-life testing / confirmation by one (or all!) of you (incl. running the db update) - before we can merge it.