KJ Tsanaktsidis comments

Results 83 comments of


                                            KJ Tsanaktsidis

Searching only helperDirs directories for helpers

I'm happy to make a PR, but wanted the maintainers to give an opinion on this first!

[WIP] Prototype of PollContext

@pavelnikolov You might don't care about this after two and a half years, but I think I implemented PollContext with cancellation in this PR: https://github.com/confluentinc/confluent-kafka-go/pull/518

Implement feature to read by partition

Hey @jasimsulaiman, just FYI - I needed this functionality in my app, and I also needed event-based polling (https://github.com/confluentinc/confluent-kafka-go/pull/518). So I merged this change into my tree on top of...

Replace librdkafka event polling with IO event triggering

Oh, forgot about the CLA. Our legal team seems to turn these around in a couple of weeks... should give us plenty of time to iterate on the PR 😂

Replace librdkafka event polling with IO event triggering

[clabot:check]

Replace librdkafka event polling with IO event triggering

@edenhill - finally got the CLA signed, so interested in your opinions on this change :)

Replace librdkafka event polling with IO event triggering

@mhowlett @edenhill Ok, took a bit longer than I was hoping, but I think I've got a version of this PR up that uses `rd_kafka_queue_yield` as you suggested. I made...

Make event polling interruptable with rd_kafka_queue_yield

[clabot:check]

Make event polling interruptable with rd_kafka_queue_yield

@edenhill I think I've addressed your feedback - PTAL when you get a chance? 🙏 thanks!

Make event polling interruptable with rd_kafka_queue_yield

Also - since I've been mucking around with the cgo machinery - I ran the test suite a few times on my machine with `GODEBUG=cgocheck=2`. This actually shook out some...