Jzjsnow

Results 17 comments of Jzjsnow

Hi @zhongqishang , I noticed that the `Duration` on the `Optimizing > Tables` page is displayed using `formatMS2DisplayTime`, while the `Duration` in Optimizing process detail page uses `formatMS2Time`. https://github.com/apache/amoro/blob/aa379e276055ea4faa9b18d0da60b4525af9fe64/amoro-web/src/utils/index.ts#L57-L126 Meanwhile,...

I agree that it's more friendly to display the time in a readable way on the page. I think we can swap what is displayed in the table and the...

Now I'm thinking that we can provide an interface by implementing which developers can customize the decryption method and choose the appropriate dependency library themselves. This way we can bypass...

In #3396, I first provide this interface `ConfigShade` and the implementation `org.apache.amoro.config.shade.impl.Base64ConfigShade` for base64 encoding. I think that by implementing the `ConfigShade#initialize` and `ConfigShade#decrypt` methods, it is possible to satisfy...

> Hi, Thanks for driving this. > > After I listed all SQL related to `table_optimizing_process`, I found that the condition of some SQL does not contain `table_name`, which may...

> I think the `table_optimizing_process` might only need a globally unique ID as the primary key, without necessarily including `table_name`. However, the current ID generation rules do indeed carry a...

> @Jzjsnow Hi,After resolving the conflict, we can continue with the review @czy006 Sure, I've resolved the conflict and rebased the changes. PTAL

@xxubai @zhoujinsong Thanks a lot for the feedback! We’ve made the change to use Snowflake IDs instead of timestamps. This should fix the uniqueness processId issue between different groups mentioned...

> I read that the implementation is to clean up expired table meta information before the table service is initialised. Is this a requirement to manually restart AMS when an...

We’ve added a new endpoint `/api/token/calculate/signature` in #3746 to help generate signatures based on query params and apiKey. This endpoint can be used by clients to verify the correctness of...