amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[Improvement]: Improve the display of `Duration` in the page of `Optimizing>Tables`

Open zhongqishang opened this issue 1 year ago • 5 comments

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

Improve the display of Duration in the page of Optimizing>Tables, same as with Optimizing process detail page.

image

How should we improve?

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

zhongqishang avatar Jan 30 '24 09:01 zhongqishang

Kindly to ask if there is somebody working for this issue? If not, I'm glad to undertake it.

old-fish-567 avatar Mar 28 '24 14:03 old-fish-567

@zhongqishang

old-fish-567 avatar Mar 28 '24 14:03 old-fish-567

Kindly to ask if there is somebody working for this issue? If not, I'm glad to undertake it.

@old-fish-567 Welcome, assigned to you.

zhongqishang avatar Mar 29 '24 01:03 zhongqishang

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

github-actions[bot] avatar Sep 26 '24 00:09 github-actions[bot]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

github-actions[bot] avatar Oct 10 '24 00:10 github-actions[bot]

Hi @zhongqishang , I noticed that the Duration on the Optimizing > Tables page is displayed using formatMS2DisplayTime, while the Duration in Optimizing process detail page uses formatMS2Time.

https://github.com/apache/amoro/blob/aa379e276055ea4faa9b18d0da60b4525af9fe64/amoro-web/src/utils/index.ts#L57-L126

Meanwhile, when hovering over the Duration on the Optimizing > Tables page, the displayed result in the hover box is the “formatMS2Time” formatted result, which is the same format as the duration display on the Optimization Process Detail page.

Image

Could you please clarify the purpose and intent behind this optimization? I am a bit confused because the initial design might have intended to display these durations differently, which is why different methods were used.

Jzjsnow avatar Jul 23 '25 10:07 Jzjsnow

Could you please clarify the purpose and intent behind this optimization? I am a bit confused because the initial design might have intended to display these durations differently, which is why different methods were used.

@Jzjsnow It is better to display a readable and friendly format directly without hovering. Another point is to keep it consistent with the time formatting of other pages (Optimizing Page). WDYT?

Image

zhongqishang avatar Jul 23 '25 11:07 zhongqishang

I agree that it's more friendly to display the time in a readable way on the page. I think we can swap what is displayed in the table and the hover box, so that if the user wants to see what was displayed before, they can hover over it with the mouse.

Before: Image

After: Image

Jzjsnow avatar Jul 27 '25 07:07 Jzjsnow