Justin Grote
Justin Grote
OK, all tests pass in CI now :). I'll do my best to get a first-pass review done sometime this week, and provide devcontainer/codespaces instructions to allow people to test...
Looking pretty good so far in terms of design, some cleanup will be needed. Several foreach rename issues I've already come across, I'll try to define tests for these when...
We will also need to make sure we account for the scoping issues as mentioned by Rob that are very difficult to handle, even if it means we warn about...
@Razmo99 uh I don't know what I did but a bunch of non-matching main commits showed up, it's not letting me force push a reset, can you please revert to...
Rebased so tests can run again.
I've started a new branch that refactors things to the LSP native rename functions, which has the main advantages of requiring no client side code, so should "just work" in...
Here's a build from the new alpha branch [powershell-2024.2.2-renameAlpha2.zip](https://github.com/user-attachments/files/17138055/powershell-2024.2.2-renameAlpha2.zip)
@Razmo99 once I finish things up and get all tests passing I'll have you help me with more scenarios and ASTVisitor rework, there's others who will jump in too. It'll...
Here is also the new branch for vscode-powershell client side, the only thing needed ATM is definition of the new settings. https://github.com/PowerShell/vscode-powershell/tree/feature/lsp-rename
JustinGrote