Justin Grote

Results 875 comments of Justin Grote

@andschwa I think I may abandon this PR in favor of the lazy variable inititialization if it is a scriptproperty like Typescript does it, seems like the better way to...

@andschwa noticed that "add to watch" is bugged and only adds the last property if you choose a dependent item (which results in it not watching what you want). Probably...

https://github.com/OmniSharp/csharp-language-server-protocol/issues/682 https://github.com/PowerShell/PowerShellEditorServices/blob/18ad303fa027705f9643fc7799558c900b65a520/test/PowerShellEditorServices.Test.E2E/DebugAdapterProtocolMessageTests.cs#L203-L204

@andschwa @SeeminglyScience there's lots of "fire and forget" async calls in the code base. Should I work on handling these or should we add a suppression to the warnings and...

Do you mean use this to generate the tie-ins to Omnisharp ABCs?

@SeeminglyScience looks like it's not hard-hanging, just a performance issue. Could this have to do with the marshaling still? https://user-images.githubusercontent.com/15258962/151478261-4f93b844-b432-41ee-ba6b-399335ff7db7.mp4

Narrowed it down to this loop for enumerables that is "slow", I'll dig deeper into `VariableDetails` later. https://github.com/PowerShell/PowerShellEditorServices/blob/624fe30eda7b7dc918978e238a59b26b81a40dc7/src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs#L338-L344

Here's the culprit: https://github.com/PowerShell/PowerShellEditorServices/blob/624fe30eda7b7dc918978e238a59b26b81a40dc7/src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs#L198 If you set it to null instead of `SafeToString()`, everything is fast again.

More specifically: https://github.com/PowerShell/PowerShellEditorServices/blob/3274c230cc6675859d5c89d6c176219c2c9430f7/src/PowerShellEditorServices/Utility/Extensions.cs#L25 @SeeminglyScience how would I get this obj.ToString() method on the correct invocation? It does feel like about a 250ms delay on each invocation.

Adding @SeeminglyScience as I've hit my limits on figuring this out for now :)