Justin Grote

Results 875 comments of Justin Grote

Good catch! This is probably an edge case that hasn't been handled. Thanks for the detailed report.

@SeeminglyScience without looking at the code I assume the API is the same one when you call a constructor without parens: ![image](https://github.com/PowerShell/vscode-powershell/assets/15258962/44227f04-4d04-4b67-b07f-6687806f72ff) If so, can we "fudge" the completion request...

Right, order by autocomplete matches and then sort the vscode lexical recommendations to the bottom. This should of course be configurable with a setting for people who prefer the other...

Prior art I've seen shows there's no specific vscode API, it's either implemented as a vscode command, as an additional context menu "quick fix all", or both. https://www.youtube.com/watch?v=GEoSWzdQsno&t=53s

Now that https://github.com/Microsoft/vscode/issues/13267 is closed, can we revisit this? It is super annoying still...

Can confirm, I just got so used to it happening that I never stopped to notice when it didn't happen. Cool beans!

@rjmholt @TylerLeonhardt Actually this is still an issue at least with "Reload Window" and should be reopened, I just didn't look closely enough. ### Steps to reproduce: 1. Start window...

> ah I see... that's because the Terminal pane is open and by default it opens your default shell... Correct, in the past there was nothing you could do about...

Related issue that was abandoned. https://github.com/microsoft/vscode/issues/39137 Here's a workaround script maybe that can be integrated https://github.com/microsoft/vscode/issues/39137#issuecomment-414127477 EDIT: Also a dispose API for terminals if we can establish some safe parameters...

The only issue I can think of is that people who have format-on-save set are gonna have a lot of suddenly large git commits and not understand why. I think...