Eng Zer Jun

Results 77 comments of Eng Zer Jun

@sfc-gh-igarish Windows handle open files differently so we need to close all open file descriptors explicitly. I've found a few places where we missed adding `.Close()`, and I have added...

Hello @Samyoul @jrainville @osmaczko. I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago. I would be grateful if...

> @Juneezee FYI in future the best way to get a review is to select some reviewers for your PR. You can just use the suggested reviewers if you are...

@Samyoul All the tests finally passed :smile: Please take a look again. Thank you.

@Samyoul I don't have the permission to merge. Please merge it for me. Thank you ![image](https://user-images.githubusercontent.com/20135478/234642678-9dd6dcab-dccb-4e11-b7a9-d290018c6bb7.png)

Hello @Amier3 @dhiaayachi @NiniOak @loshz . I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago. I would be...

Rebased and resolved conflicts in - `agent/consul/client_test.go` - `agent/grpc-internal/client_test.go`

Already fixed by https://github.com/googleapis/api-linter/pull/1182 ?

We can close this issue. Already implemented in https://github.com/googleapis/api-linter/pull/1156

Go 1.23 is released https://go.dev/blog/go1.23 We can start working on this after we bump our minimum supported version to Go 1.22 [^1]. [^1]: https://go.dev/doc/go1.22#math_rand_v2