Eng Zer Jun comments

Results 77 comments of


                                            Eng Zer Jun

Why aria attributes have no default values in Buefy?

@jtommy Considering that Buefy is currently used by ~10.7k repositories and more, I think there is no harm in setting the aria attributes by default. In addition, it improves the...

test: use `T.TempDir` to create temporary test directory

> Thank you for the contribution. This seems like the right change to make to simplify temporary file handling in our test cases. Unfortunately, I did not see this PR...

test: use `T.TempDir` to create temporary test directory

Rebased onto `master` and fixed two new failing tests on Windows

test: use `T.TempDir` to create temporary test directory

Rebased onto `master` and resolved conflicts in `tsdb/index/tsi1/index_test.go`.

test: use `T.TempDir` to create temporary test directory

Rebased onto `master`.

test: use `T.TempDir` to create temporary test directory

Rebased onto `master`.

test: use `T.TempDir` to create temporary test directory

Rebased onto `master`.

fix: add uuid dependency

@pSnehanshu The problem was introduced in `v3.0.1`. `v3.0.0` does not have this problem.

missing dependency: uuid

This issue is already reported here: #355

fix: replace missing uuid dependency with crypto.randomUUID

> crypto.randomUUID([options]) Added in: v15.6.0, v14.17.0 @Privatecoder We might need to set Node.js version restriction in `package.json` (https://docs.npmjs.com/cli/v8/configuring-npm/package-json#engines) because `crypto.randomUUID` is not available on (very) old Node.js versions. Some people...