refactor: replace strings.Replace with strings.ReplaceAll

[Juneezee]

Description

Replace strings.Replace(s, old, new, -1) with strings.ReplaceAll(s, old, new). strings.ReplaceAll is a wrapper function for strings.Replace, but strings.ReplaceAll is more readable and removes the hardcoded -1.

PR Checklist

• [x] not a security concern

[Amier3]

Hey @Juneezee

Thanks for making this PR. Apologies for the late response it looks like we missed this one for some reason. Since we're close to a release and to HashiConf EU, it might take us a a couple weeks to get to this.

There's some nomad integration tests failing at the moment so we'll also have to investigate that.

[Juneezee]

Rebased onto main and resolved conflicts in agent/grpc/private/client_test.go.

[Juneezee]

Hello @Amier3 @dhiaayachi @NiniOak @loshz . I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago.

I would be grateful if you could take some time to review the changes and provide me with your feedback. If there are any specific concerns or questions you have about the changes, I am more than willing to help address them.

Thank you for your time and consideration. I truly appreciate it. :heart:

[Juneezee]

Rebased and resolved conflicts in

• agent/consul/client_test.go
• agent/grpc-internal/client_test.go

[vercel[bot]]

@Juneezee is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.