buefy icon indicating copy to clipboard operation
buefy copied to clipboard
verified publisher icon buefy

Why aria attributes have no default values in Buefy?

Open Juneezee opened this issue 5 years ago • 3 comments

Description

Take the pagination image

and tag component for example, image

Is there any particular reason that the aria labels are not set by default in Buefy?

Why Buefy need this feature

Improve accessibility for screen readers

Juneezee avatar May 22 '20 12:05 Juneezee

@Juneezee To be honest there isn't a reason, do you prefer to see a default value ?

jtommy avatar May 25 '20 06:05 jtommy

@jtommy Considering that Buefy is currently used by ~10.7k repositories and more, I think there is no harm in setting the aria attributes by default. In addition, it improves the accessibility of Buefy components too.

Juneezee avatar May 25 '20 07:05 Juneezee

It could be a breaking change though. There are probably a lot of the 10.7k repository that are not in english. Buefy is (not entirely) kind of langage agnostic right now. It would need to have some way to change those easily (maybe as constructor options).

service-paradis avatar May 26 '20 01:05 service-paradis

Hello, from three years in the future 🤣 Does anyone know if I should just close this PR or should this still be a goal for Buefy v2? @jtommy @service-paradis @kikuomax @wesdevpro

wesdevpro avatar Oct 11 '23 04:10 wesdevpro