Julian Berman

Results 366 comments of Julian Berman

I see. `validator_for` could possibly interact better with these kinds of attempts to "override" a draft's validator, but probably in the interim it's yeah easy enough just for you to...

(I strongly doubt this issue has anything to do with #853, as I said somewhere above -- #853 should now be fixed after some unrelated caching.)

I wouldn't be so sure, I'd suspect users who have found the `Validator` classes will know, just like in normal Python code, that if you want to do things many...

Thanks @nezhar -- not sure how I feel about needing to be this explicit -- let me give playing with this PR locally a bit a shot. Will follow up...

This is going to require some significant changes (and new API), so with apologies (especially for again having these sit here), I'm going to close this for now.

I'll respond in more detail on the core issue here, but > For instance, for an "additionalProperties" keyword, [looking at the code](https://github.com/python-jsonschema/jsonschema/blob/main/jsonschema/_validators.py#L38) shows that there is some logic that needs...

Isn't the relevant value in the `minContains` example just `error.validator_value`? The code today doesn't calculate the total number of matches, it stops once that's met -- maybe that's what you...

Ah indeed, ok yeah that's certainly a bug (regardless of the original topic).

This is going to require some significant changes (and new API), so with apologies (especially for again having these sit here), I'm going to close this for now.

Thanks -- the minimized example certainly looks good -- the next steps would be a change was just merged fixing dynamicRef support (in that all tests of it in the...