Julian Berman

Results 366 comments of Julian Berman

This is due to check_schema validating schemas via format annotation rather than assertion. Technically that's unfortunately not incorrect behavior, even if it's a footgun. I'll leave this open and consider...

I'll follow up with a longer reply when I get a sec (sorry) -- the general answer I've had for this question has been "error messages are for developers, not...

That's a feature, not a bug :) -- what makes you say it's a bug? Tracebacks are not meant to be _falsely_ consistent, they should tell the developer what's wrong...

@fzdarsky I'm all for making things more usable! Please don't take any of this as shooting down ideas :) I think a developer who's _using_ jsonschema **should** be just as...

@ramanshah I forget if I've seen that library before, but from a quick 10 second read it's quite minimal in what it changes. I'm all for making the tracebacks as...

For more examples here, see the schema+instance in #350 which produces a ridiculous output. The problem there is more about indentation, but let's be sure we cover it.

The standard library *dumps* non-string valued dicts by coercing them to JSON first and then dumping that. It will never *load* back a dict that can't come from valid JSON...

> Should I assume that jsonschemas behaviour is undefined for instances that were not loaded from valid JSON (but, e.g., programmatically created to later be serialised)? Even if they would...

I am all for an incremental fix if it's small and self contained! Would definitely be appreciated. Just have to be careful to preserve backwards compatibility for any custom defined...

Hey! It's not explicitly a goal to be threadsafe, generally I'd recommend just creating a different validator for each thread, but having `_scope_stack` not be scoped to each call might...