jsonschema icon indicating copy to clipboard operation
jsonschema copied to clipboard

Split contains, maxContains and minContains beetween applicator and validation vocabulary

Open nezhar opened this issue 2 years ago • 1 comments

This is an addition to https://github.com/Julian/jsonschema/pull/924/ in order to provide support vor contains, maxContains and minContains based on the defined vocabulary in the meta schema. Before the 3 keywords where handled in contains, but since they are part of diefrent vocabularies, they should be handled on their own.

nezhar avatar Mar 08 '22 16:03 nezhar

Codecov Report

Merging #925 (5964fca) into main (ee5d31a) will decrease coverage by 0.05%. The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
- Coverage   97.02%   96.96%   -0.06%     
==========================================
  Files          20       20              
  Lines        3295     3362      +67     
  Branches      458      478      +20     
==========================================
+ Hits         3197     3260      +63     
- Misses         77       79       +2     
- Partials       21       23       +2     
Impacted Files Coverage Δ
jsonschema/tests/test_jsonschema_test_suite.py 82.35% <ø> (ø)
jsonschema/_validators.py 98.57% <82.60%> (-1.43%) :arrow_down:
jsonschema/tests/test_validators.py 98.09% <100.00%> (ø)
jsonschema/validators.py 97.54% <100.00%> (+0.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee5d31a...5964fca. Read the comment docs.

codecov[bot] avatar Mar 08 '22 16:03 codecov[bot]

This is going to require some significant changes (and new API), so with apologies (especially for again having these sit here), I'm going to close this for now.

Julian avatar Sep 09 '22 08:09 Julian