Jorge Rodriguez (A.K.A. Tiriel)

Results 44 comments of Jorge Rodriguez (A.K.A. Tiriel)

@noxdafox How about moving the plugins from the root to `see/lib/plugins` instead? We could move the image providers there too. The context as well, maybe?

I would go for option nr. 2

@Andersson007 @bmalynovytch @bmildren I'm not quite sure how to write tests for this, other than running the module with the new options and check that the sent query matches expectation...

@Andersson007 the sanity checks say I can't define choices for an integer parameter. What's the proper way to define an `int` within a specific range of values?

@bmalynovytch since all of the options to `CHANGE MASTER TO` are optional and we aren't testing the `MASTER_HOST` or `MASTER_PORT` options (those are already tested) couldn't we test everything against...

> > @Andersson007 the sanity checks say I can't define choices for an integer parameter. What's the proper way to define an `int` within a specific range of values? >...

I'm going to abandon this PR draft, as it relates to replication and we have modifications regarding that component and the language used. That being said, I'd like to keep...

@securitym0nkey couldn't agree more. Could you link the documentation for this feature? @Andersson007 I can take this one

Just need to add the conditional assertions for versions that do not support this feature

@Andersson007 @martinwalle only test fixes are missing, the functional code is ready for manual testing.