see
see copied to clipboard
SEE setup.py is packaging the plugins
Hi,
I noticed that when i install python-see from pip, the plugins are also installed:
In [1]: import plugins
In [2]: plugins.__file__
Out[2]: '/usr/local/lib/python3.6/dist-packages/python_see-1.2.6-py3.6.egg/plugins/__init__.py'
In [3]:
Having a vague named such as plugins installed as a system wide module is a bit dangerous don't you think ?
Thanks.
@noxdafox How about moving the plugins from the root to see/lib/plugins instead?
We could move the image providers there too. The context as well, maybe?
2 solutions:
- move them into a seperate package
python-see-plugins - integrate them into the see package
see.plugins
I would go for option nr. 2
The plugins folder was initially intended as a place where to provide some reference implementation of SEE plugins. It ended up in the package by mistake.
Nevertheless, I think it might be a good idea to add it to the Python package. I will provide soon a patch for moving it to see.plugins. I think is the most sensible solution.