see icon indicating copy to clipboard operation
see copied to clipboard

SEE setup.py is packaging the plugins

Open Wenzel opened this issue 7 years ago • 4 comments

Hi,

I noticed that when i install python-see from pip, the plugins are also installed:

In [1]: import plugins

In [2]: plugins.__file__
Out[2]: '/usr/local/lib/python3.6/dist-packages/python_see-1.2.6-py3.6.egg/plugins/__init__.py'

In [3]: 

Having a vague named such as plugins installed as a system wide module is a bit dangerous don't you think ?

Thanks.

Wenzel avatar Jun 21 '18 12:06 Wenzel

@noxdafox How about moving the plugins from the root to see/lib/plugins instead? We could move the image providers there too. The context as well, maybe?

Jorge-Rodriguez avatar Jun 23 '18 10:06 Jorge-Rodriguez

2 solutions:

  • move them into a seperate package python-see-plugins
  • integrate them into the see package see.plugins

Wenzel avatar Jun 23 '18 10:06 Wenzel

I would go for option nr. 2

Jorge-Rodriguez avatar Jun 23 '18 11:06 Jorge-Rodriguez

The plugins folder was initially intended as a place where to provide some reference implementation of SEE plugins. It ended up in the package by mistake.

Nevertheless, I think it might be a good idea to add it to the Python package. I will provide soon a patch for moving it to see.plugins. I think is the most sensible solution.

noxdafox avatar Jun 27 '18 11:06 noxdafox