Joost Koehoorn

Results 268 comments of Joost Koehoorn

Hi folks, an update on this issue: the upcoming v14 will suppress the error for classes with the `abstract` keyword. Instead, it reports an error on a concrete subclass _iff_...

Sharing an update here: `15.0.0-next.6` has just been released which contains a change regarding this issue, such that `abstract` classes are now exempt from `strictInjectionParameters`. In contrast, the compiler is...

You're experiencing #33724, where Ivy also AOT compiles non-exported classes, unlike ViewEngine. Test files are typically not processed by the AOT compiler so this isn't an issue for most people,...

Whether or not it's safe is up to your situation. You may not want to enable it for your production compilation unit, as any non-exported classes will then fallback to...

Yes, this is an issue. We generate: ```ts "" + ((((null as any) ? (((ctx).prop /*24,28*/) /*24,28*/)!.nested : undefined) /*24,36*/).field /*37,42*/) /*24,42*/; ``` which is obviously broken. A workaround could...

@ajafff I think it's worth capturing that as an issue by itself, regardless of how #34385 is dealt with.

> @JoostK > > > Yes, this is an issue. We generate: > > > ```ts > > > "" + ((((null as any) ? (((ctx).prop /*24,28*/) /*24,28*/)!.nested : undefined)...

> Perhaps this tree reshaping logic from the compiler should be duplicated in the typechecker. Or maybe perform it once - before even passing the AST to compiler and typechecker....

I wouldn't have suspected quite such a steep increase in memory usage (and I almost glanced over it at first because there is no red icon shown in the memory...