Joost Koehoorn

Results 268 comments of Joost Koehoorn

Oh hey, I have a local patch for this exact bug dating back to december 2018. I just never got around to reporting an issue here. I recall having debugged...

Could you please share a runnable reproduction that showcases this situation; it's otherwise unactionable to us as it's unclear where any bottlenecks may occur.

There was a fix for `extract-i18n` in CLI 14.0.3. I don't know enough about the i18n pipeline to tell why the `$localize` calls are not translated during build time. A...

This seems to be an interesting case, which I agree behaves unexpectedly. The router creates the routed component dynamically, entering this code path: https://github.com/angular/angular/blob/dbb0dfe70731b1050ed7a7d6892ec01c3c8a0513/packages/core/src/linker/view_container_ref.ts#L408-L413 Here, `this.parentInjector` is a node injector...

@pkozlowski-opensource and myself looked into this again today, and we've come to the conclusion that this is working as designed (although confusing). What happens is that the `` creates the...

This looks suspect: https://github.com/angular/angular/blob/0bf6e58db2e416603f75bf232b225008b82adeaf/packages/core/src/render3/jit/module.ts#L230-L236 The `getDirectiveDef` call finds the abstract directive as compiled by Ivy, but doesn't notice that the type is actually a pipe.

This issue is still missing relevant details for us to understand the problem you're experiencing, and what the cause of this issue might be. Please provide a minimal reproduction if...

This is caused by #28162; I'm currently exploring ways to fix this issue.

I have a preliminary PR up at #45516 that attempts to avoid this issue. It is non-trivial and I suspect there may be some animation scenarios that it won't cover...

Hi @basti-n, Thank you for your contribution. We've just discussed this issue some more and we'd like to take a step back to evaluate how multi providers currently work and...