Joost Koehoorn

Results 268 comments of Joost Koehoorn

The docs suggest using native `fetch`, not the `fetch` backend for `HttpClient`. I think it's a fair point to have more info on the distinction. And indeed, interceptors are specific...

I don't think that an initial value should be made mandatory, but I can see how an overload like ```ts function input(initialValue: undefined, options: InputOptionsWithoutTransform): InputSignal; ``` could potentially help...

This is _super_ weird. With the `application` builder (using vite/esbuild) I see the following: ```ts ✘ [ERROR] function setExternalModuleIndicator(sourceFile) { sourceFile.externalModuleIndicator = isFileProbablyExternalModule(sourceFile); } could not be cloned. [plugin angular-compiler]...

The intent of that comment is to make people aware of _potential_ security implications of the schema definitions. For example, Angular must sanitize data when binding to the `innerHTML` property,...

Could you please squash the commits? The revert won't be auto squashed otherwise

Looks like something went wrong, there's now five commits.

Sharing an additional data point here as well (from https://github.com/evanw/esbuild/issues/3156#issuecomment-1587445800): the issue only reproduces for me using Docker Engine 24, whereas the image works fine using Docker Engine 20. Tested...

> what if I need to use "RouterModule.forChild" in a standalone component? How can I do it manually? Cannot find a solution. It can't be done, because it's designed not...

`Route.providers` does accept the usage of `importProvidersFrom` since it creates an environment injector to create the routed component in.

I think what I'd do in this case is to split the component into an abstract directive and a concrete component, where inheritors would then have to extend the directive...