JoostBuitink comments

Results 11 comments of


                                            JoostBuitink

Refactor: initialize function, (long) structs, `Model` struct fields

Issue #326 is linked to this refactor, and should be discussed in the design session

Refactor: initialize function, (long) structs, `Model` struct fields

#243 is also linked to this, and should be done in parallel

Unicode Character Usage and Consistency

We have decided to stop using unicode characters, and spell them out if necessary (for example `theta_s` instead of the Greek symbol). We aim for the variables to be as...

Enhanced Flexibility in Groundwater Setup

see main issue #351

Send error if glacier is true and state/parameters are missing

I think this is the same issue as issue #293, right? I also think think this might be a good issue to tackle for a v1.0

Send error if glacier is true and state/parameters are missing

Ah I see, yes that makes sense!

Create Dockerfile and host image publically

Thanks again for picking this up @evetion! It would also be really nice if previous versions of wflow remain accessible through their version as a tag (so `wflow:v0.6.3` for example)....

Create Dockerfile and host image publically

Ah right, that makes sense! We are indeed planning to merge the wflow_cli repo to here, so lets do that first!

Create Dockerfile and host image publically

That would be great! I have added the wflow_cli code to this branch https://github.com/Deltares/Wflow.jl/tree/merge_cli. Is there anything else that needs to be added? I see that in Ribasim.jl you have...

Replace use of `LoopVectorization` in local inertial model `stable_timestep` function with `Polyester` (`reduction`)

I did a couple of checks with the model that produced errors, and this branch seems to indeed fix it! @shartgring will also do a check, since he just ran...