Wflow.jl icon indicating copy to clipboard operation
Wflow.jl copied to clipboard

Send error if glacier is true and state/parameters are missing

Open hboisgon opened this issue 1 year ago • 3 comments

Feature type

Changing existing functionality

Improvement Description

When setting glacier = true in TOML, wflow does not send an error if the state (and parameters) are missing, the way it does for lakes or reservoirs. So if you are a bit forgetful, while you think you model glaciers in fact you do not (if glacierfrac is not found then it defaults to 0 so no glaciers).

Implementation Description

Maybe like for lake and reservoirs, make the glacierfrac and glacierstore parameter and states mandatory (optional=False) if glaciers is True?

Additional Context

No response

hboisgon avatar Dec 22 '23 07:12 hboisgon

I think this is the same issue as issue #293, right? I also think think this might be a good issue to tackle for a v1.0

JoostBuitink avatar Dec 22 '23 07:12 JoostBuitink

Partly, I would also like the error if using cold states in that case (so make glacierfrac mandatory?)

hboisgon avatar Dec 22 '23 08:12 hboisgon

Ah I see, yes that makes sense!

JoostBuitink avatar Dec 22 '23 08:12 JoostBuitink