Jonathan Wilbur
Jonathan Wilbur
All feedback addressed. This PR is ready for further review. @t8m can I get a style check exception for this one? @nhorman would you be interested in reviewing this?
> Hmm... CI is failing. That's my fault. I forgot the NID change means I need to re-order `standard_exts.h`.
@nhorman This is ready for review.
Welp, since GitHub won't allow me to upload a Wireshark packet capture, here is the full UDP stream. Hopefully this helps: ``` INVITE sip:[email protected]:5060 SIP/2.0 Via: SIP/2.0/UDP 192.168.1.215:47798;branch=z9hG4bK.vS~qqsS~T;rport From: "Linphone...
All feedback addressed and ready for review.
@nhorman does this mean that the style checks are no longer experimental and I should pay attention to them?
Feedback addressed and ready for review.
I did this in a TypeScript project and it worked for me: `import * as nsfwjs from "./node_modules/nsfwjs/dist/cjs/index.js";`. That's obviously sloppy; you shouldn't have to do it. But it works.
I think this explains why I do not see `BYE` messages sent when I hang up. I feel like this is a recent problem, because I was doing Wireshark captures...
This seems to have started with Linphone Android 5.1.0 / Linphone SDK 5.2.96.