Jonathan Wilbur
Jonathan Wilbur
All feedback addressed and ready to review.
Fetched, rebased, and force-pushed to fix the merge conflict in `libcrypto.num`.
I had to fix an incorrectly-named OID in this PR.
I forgot to reorder the extensions after changing the NID.
@levitte I think one problem with your approach is that it causes `auditIdentity` to have a different NID. The `OBJ_` is aliased, but the NID is not, which means we...
> @levitte I think one problem with your approach is that it causes `auditIdentity` to have a different NID. The `OBJ_` is aliased, but the NID is not, which means...
@t8m Should I consider this a bug in the aliasing code itself and try to fix it before this gets merged in?
> How does the full change look like if you use the !Alias? ```diff diff --git a/include/openssl/obj_mac.h b/include/openssl/obj_mac.h index d77ba94bd8..67d038f7a5 100644 --- a/include/openssl/obj_mac.h +++ b/include/openssl/obj_mac.h @@ -1583,10 +1583,13 @@ #define...
@t8m I don't know if we'll hear back from @levitte at this point. Should we get an opinion from somebody else?
@t8m Can I just get rid of the spelling corrections and use the incorrect name for now? It seems like we're just not getting any feedback from anybody, and this...