Jonathan Wilbur comments

Results 53 comments of


                                            Jonathan Wilbur

Added toBytes property to std.bigint.BigInt

That punycode commit you see there was from a previous pull request. I removed it in a subsequent commit.

Added toBytes property to std.bigint.BigInt

Oh, also, the main rationale--the one I suspect everybody has for wanting this property--is the ability to convert large integers to arrays of bytes for ASN.1 encoding in RSA data...

Added toBytes property to std.bigint.BigInt

@wilzbach , I do not have a machine for testing on `BigEndian`. Actually, I assumed that one of the hosts in the D Auto-Tester fleet would be big endian...

Added toBytes property to std.bigint.BigInt

Also, I don't think that Circle CI failure is my fault: it says that Dscanner failed. I didn't change anything about Dscanner.

Added toBytes property to std.bigint.BigInt

So what is the next step? Does somebody else need to review this? Do I need to change something?

Added toBytes property to std.bigint.BigInt

@Biotronic , I guess you missed it, but I already moved most of it to biguintcore.d. Please review it again.

Added toBytes property to std.bigint.BigInt

Just following up on this, @wilzbach (or anybody else), is there a reason this has not been merged yet? Do I need to change anything? I should also add that...

Add groupAC, noAssertion, SOAIdentifier, and noRevAvail exts

@t8m Just checking: you aren't waiting on me for anything, are you?

Add groupAC, noAssertion, SOAIdentifier, and noRevAvail exts

@t8m I have addressed the outstanding code review issues and re-worded the first commit to mention the added attribute certificate extension object identifiers.

How do you create a Vec<u8> or &[u8]?

I should add that this differs from #66 because I do not want to write empty trailing bytes. I only want to write bytes that have bits used in them.