Zele comments

Results 7 comments of


                                            Zele

Ns1r integration test does not fail with greater than 4 senders

Do we have an actual payload size validation

Wrap URI errors in a payjoin type

Let me take a look at this

Wrap URI errors in a payjoin type

[PR](https://github.com/payjoin/rust-payjoin/pull/657) Edit: I had to close the previous pr since it did not capture the changes made. See new pr here: [#661](https://github.com/payjoin/rust-payjoin/pull/661)

InputPair's lack of a constructor seems to cause mistakes

Hi @DanGould Let me pick this up

InputPair's lack of a constructor seems to cause mistakes

[https://github.com/payjoin/rust-payjoin/pull/641](url) Addressing this in PR @DanGould

feat(receive): Add tests for InputPair constructors Closes #583

PR Updated: - Removed `test_new_p2wpkh` as suggested - Cleaned up test comments for better readability - All tests are passing - Added comprehensive test coverage: - `test_privacy_based_input_selection`: Tests UIH avoidance...

`check_no_inputs_seen_before` callback should not need to manage its own state

From my reading of #894 and the review thread on PR #883 the goal is to remove the side-effect (recording seen inputs) from `check_no_inputs_seen_before` and let the library supply that...