JohnnyMorganz
JohnnyMorganz
Hey, no progress unfortunately. I haven't had the chance to work on full-moon yet. We still need to also update full-moon in stylua too, but it currently has some stack...
I think most of these should work already in stylua due to overlap with the Luau syntax. What code is currently failing to format with stylua?
For reference, the reason why we handle positional args like that is at https://github.com/JohnnyMorganz/StyLua/issues/276#issuecomment-937968657. I'm not a particular big fan of it (makes the code for stylua a lot more...
The problem here is we eagerly select a different codepath because of the singleline comment in the first example. It is difficult to detect this comment without being too expensive...
> To resolve your example, I think the better solution is to set stylua.searchParentDirectories to true, in addition to the new changes in this PR. This has unintended side-effects, which...
Hah, forgot about this. It might've been because of https://github.com/JohnnyMorganz/luau-lsp/commit/7caf060043ebfed663d3f78fc8056a39c57aa491
This has been fixed upstream which has been pulled in https://github.com/JohnnyMorganz/luau-lsp/commit/cd24f390b8c7d1f72f83d73ff788148d46ba076b
Fixes for this issue have been pushed upstream :) It should be available in the next LSP release in the next few days. It will currently require enabling the FFlag...
Documentation for setting up new editors has been added at https://github.com/JohnnyMorganz/luau-lsp/blob/main/editors/README.md If any users are interested in contributing their own client, feel free to open a PR
Going to close this as it seems more of a pre-commit / aftman issue than stylua. Let me know if you have any further questions about it