StyLua icon indicating copy to clipboard operation
StyLua copied to clipboard

Question- Support ? and ` characters?

Open Gellipapa opened this issue 1 year ago • 10 comments

I've recreated the issue because now the full-moon has been rewritten.

@JohnnyMorganz Hi! I recently asked the creator of full-moon about when the parse rewrite will be done and he said that it will be done before the end of the day. I checked the next day and it was already merged.

I would like some help on how I can ?. and ` manage it using stylua and full-moon.

Thank you very much for your reply in advance.

Gellipapa avatar Jan 27 '24 13:01 Gellipapa

Hey, sure. I will look into adding fivem Lua support in full-moon soon

JohnnyMorganz avatar Jan 27 '24 13:01 JohnnyMorganz

Hey, sure. I will look into adding fivem Lua support in full-moon soon

Hi! Thanks for the quick reply.

If you could send me some description how to include such a charachter treatment I would be glad to have a look.

I would also be interested in implementation but thanks a lot if you do it.

Gellipapa avatar Jan 27 '24 13:01 Gellipapa

@JohnnyMorganz Hi! Can you give me some status? Have you managed to implement the logic in full-moon? Thanks for the answer in advance.

Gellipapa avatar May 18 '24 10:05 Gellipapa

Hey, no progress unfortunately. I haven't had the chance to work on full-moon yet. We still need to also update full-moon in stylua too, but it currently has some stack overflow issues that require fixing.

Do you have a list of all the Lua differences introduced in FiveM lua?

JohnnyMorganz avatar May 18 '24 14:05 JohnnyMorganz

Hey, no progress unfortunately. I haven't had the chance to work on full-moon yet. We still need to also update full-moon in stylua too, but it currently has some stack overflow issues that require fixing.

Do you have a list of all the Lua differences introduced in FiveM lua?

It's okey. I don't have a list, unfortunately, but I know about the ones that work in the FiveM lua part. ? ` += -= Thanks.

Gellipapa avatar May 18 '24 17:05 Gellipapa

I think most of these should work already in stylua due to overlap with the Luau syntax.

What code is currently failing to format with stylua?

JohnnyMorganz avatar May 18 '24 18:05 JohnnyMorganz

I think most of these should work already in stylua due to overlap with the Luau syntax.

What code is currently failing to format with stylua?

` and ? these characters.

image

https://github.com/esx-framework/esx_core/blob/main/%5Bcore%5D/esx_multicharacter/server/main.lua#L173

This was one of the errors that caused the stylua not to run.

Gellipapa avatar May 18 '24 21:05 Gellipapa

@JohnnyMorganz Hi! Sorry for ping. Can you give me some status on this? Thanks.

Gellipapa avatar Jun 04 '24 20:06 Gellipapa

@JohnnyMorganz Hi! What's up? Is there anything we can do to manage these characters?

Gellipapa avatar Aug 06 '24 19:08 Gellipapa

Very sorry, I just have not had a chance to work on this project recently. It is still on my (somewhat large) TODO list

JohnnyMorganz avatar Aug 10 '24 11:08 JohnnyMorganz