Johannes Marbach

Results 147 comments of Johannes Marbach

It's been almost 9 months since this has been opened. Given the motivation outlined in https://github.com/vector-im/element-web/issues/22748, this looks like an improvement to me as it increases the consistency of spacings...

@gaelledel could you give us a quick review on this one please?

Thank you for your contribution. @daniellekirkwood and I synced up today and have decided to proceed with https://github.com/matrix-org/matrix-react-sdk/pull/11087. I'm closing this pull request because it largely achieves the same thing...

It's not ideal that we currently don't have screenshot tests for voice messages. That being said, this looks like a relatively low-risk change to me. So I think we can...

The static analysis error stems from `develop` itself being broken yesterday. I'll merge this bypassing the check to avoid any further delays. Thanks again for your contribution, @luixxiul!

@jaiwanth-v thanks again for your contribution. Are you still interested in following up on this?

@jaiwanth-v, right, I _think_ these should be fine given that the experience is the same on the room list currently. Could you merge `develop` into your branch so that we...

@jaiwanth-v are you still planning to work on this?

I'll be closing this for now to help reduce the number of unfinished PRs. Somebody else may follow up separately. Thanks for your contribution in any case @jaiwanth-v! 🙏

This has been blocked for a _very_ long time now. Given it's obvious user value, I propose us to be more pragmatic in getting it landed and not let perfect...