matrix-org
Fix blowout of waveform of the voice message player on narrow UI
Fixes https://github.com/vector-im/element-web/issues/22604
| Before | After |
|---|---|
 |
 |
Essentially same as https://github.com/matrix-org/matrix-react-sdk/pull/8816. The issue probably should happen on any flexbox/grid with fixed width child elements.
https://css-tricks.com/preventing-a-grid-blowout/
Signed-off-by: Suguru Hirahara [email protected]
type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes
- Fix blowout of waveform of the voice message player on narrow UI (#8861). Fixes vector-im/element-web#22604. Contributed by @luixxiul.
@turt2live can we please get a message explaining why something gets blocked?
This area is highly sensitive design wise, so per other PRs I'm intending to take a look before it lands.
converting to draft for now to prevent accidental merge- please ping me after review.
It's not ideal that we currently don't have screenshot tests for voice messages. That being said, this looks like a relatively low-risk change to me. So I think we can move ahead here.
@luixxiul if you're still up for it, could you merge develop into your branch and fix the conflicts. Afterwards, please re-request review from @justjanne as this has been sitting untouched for a while.
Since I messed up merge, I force-pushed to apply the same change as the previous commit.
The static analysis error stems from develop itself being broken yesterday. I'll merge this bypassing the check to avoid any further delays. Thanks again for your contribution, @luixxiul!