matrix-react-sdk
matrix-react-sdk copied to clipboard
matrix-org
Reduce bottom margin of ReplyChain on compact modern layout
Closes https://github.com/vector-im/element-web/issues/22748
This PR reduces bottom margin of ReplyChain on compact modern layout from 8px to 4px, specifying the common margin value for both bubble and modern/group layouts on _EventTile.scss.
Input on design/UI would be appreciated.
| Before | After |
|---|---|
 |
 |
 |
 |
type: enhancement
Signed-off-by: Suguru Hirahara [email protected]
Here's what your changelog entry will look like:
✨ Features
- Reduce bottom margin of ReplyChain on compact modern layout (#8972). Fixes vector-im/element-web#22748. Contributed by @luixxiul.
I requested design review. Please ping the 3 people listed as reviewers when the design review is done. Thanks!
It's been almost 9 months since this has been opened. Given the motivation outlined in https://github.com/vector-im/element-web/issues/22748, this looks like an improvement to me as it increases the consistency of spacings in the timeline. So let's move forward on this.
Since the code has changed since the initial review, I suggest we do another review and then land it.
I should be able to implement a Percy test if there would be a test of ReplyChain already (I am not quite sure how to set it up... perhaps on timeline.spec.ts?)