Johannes Lorenz

Results 261 comments of Johannes Lorenz

~~For information, I'm still about to review this, should be finished this weekend. Would be cool if you can wait with merging.~~ Already finished.

Looking at the plan, without looking too close at the code: > * Split the search field into a separate widget, passing the search string via signals and slots. This...

Note: I consider this almost deprecated, because we have the same issues with Lv2.

> Optional should be available by now though, I believe we already bumped to the required C++ version. True, but the we have redundant information in `std::optional` and `QColor` about...

I think they are equivalent in our current code. Do you see any use case in our code where an invalid `MixerChannel::m_color` and a not-set `MixerChannel::m_color` should be handled differently?

> In my opinion, a single (possibly invalid) member of type QColor doesn't imply that having no color is an acceptable state. An optional makes it clear that we expect...

@spechtstatt The use of `std::optional` looks correct, but shouldn't it *replace* `m_hasColor`?

> @JohannesLorenz I can't drop OSC models to existing automation patterns because it's not implemented yet. Are you going to implement it? Yep, it's implemented now in 7e7044d. Also implemented:...

> I also think we should eventually integrate the build script into the LMMS repository prior to merging this, though it has less priority for now. The build script compiles...

For your most recent comment: * I merged your patch in, thanks for that. * The hard dependencies should now all be removed in 2a4ad86. * I can't reproduce it,...