Joey
Joey
importing the [UniswapV2Oracle](https://github.com/Uniswap/uniswap-v2-periphery/blob/master/contracts/libraries/UniswapV2OracleLibrary.sol) for instance results in the following header at the output of `solt write contracts/ --npm`: `2 unknown imports found, re-search?` even with the --npm flag. After researching...
This repo should add the following labels: * `testing` * `deployment` * `gas optimization`
Oracle for factory tokens like d3 and Fei Metapool Diff: https://www.diffchecker.com/Iuydduhz
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md We have a GitHub bot that automatically merges some PRs. It will merge yours...
[EDIT]: only withdraw and redeem methods in ERC-4626 use the underlying ERC-20 approval, so I edited the below to reflect that. This also simplifies the permit2 integration. Similar to https://github.com/Uniswap/universal-router/issues/176,...
I've seen multiple ERC4626 implementations use a manipulable totalAssets which can allow for flash attacks. Should add a loud warning on the function natspec
Given the “universal” goal of the router, it would be appropriate to consider including a number of instructions for ERC-4626 standard compatibility This unlocks use cases where users can swap...
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md We have a GitHub bot that automatically merges some PRs. It will merge yours...