Joey

Hey @hjubb ! Fei Protocol core from this commit has this issue: https://github.com/fei-protocol/fei-protocol-core/tree/badc36a467808184753b6378f976097a25562701. Specifically for the file `contracts/oracle/UniswapOracle.sol`

@snreynolds thanks for the quick reply! It makes most sense directly in the ERC20 permit2 contract specifically because the ERC-4626 contract directly uses the ERC-20 approval system (all ERC-4626 contracts...

@snreynolds great! Seeing the 721 or 1155 implementation will be helpful as well. If you all are committed that the contracts should be separate, then either the 4626 contract should...

Spec doesn’t need to be non-manipulable but because the shares calculations used by default rely on this value, its essential that it is non-manipulable here > On Apr 17, 2022,...

https://github.com/fei-protocol/ERC4626/blob/main/src/ERC4626Router.sol was intended to achieve this goal specifically focused on the erc4626 component, modeled after the Uni v3 router. Combining the functionality with Universal Router would multiply the available use...

Thanks @marktoda! Starting at the highest level architecture, I'd assume the right way to go is to 1. add a module similar to the Uni v2 and v3 ones with...

> Potentially cleaner though to just add a new branch (0x20-0x28). Will defer to @hensha256 on this part How hard would it be to do this? I think it would...

I also found one issue, because ERC-4626 uses the approve/transferFrom flow, the ERC-4626 example router impl has a generic approve function which is public: https://github.com/fei-protocol/ERC4626/blob/main/src/external/PeripheryPayments.sol#L30-L32 This is not a security...

Thanks for the feedback all! I believe I have enough info to get started on a PR, however I wanted to prioritize the conversation from the permit2 side https://github.com/Uniswap/permit2/issues/162 as...