João Rodrigues

Results 61 comments of João Rodrigues

This would be trivial to add, if the purpose is to write the sequence of the residues for which there are (at least one) coordinates. If the intention is to...

Hi all, Thank you for all the comments both here and on Twitter. I believe there are two aspects of integrating style checkers: local development and online CI. Adding a...

Hi @janash, Thanks for looking into this. I agree that adding a pre-commit YAML config file to the cookiecutter template repo is a good idea. Then you can simply tell...

Is black running on every file, or just the ones changed in the PR?

If I understand the argument on issue 90 referenced, I think it applies more to the usage of black automatically upon committing, instead of on the whole code base. Since...

>However, that would mean doing something other than pre-commit run -a (run on all files), and instead pre-commit run FILE1 FILE2 ... where we are passing a list of changed...

Actually, I think we are already running pre-commit locally as well, just checked the CI workflow. So maybe we can disable pre-commit.ci?

I'm a little late to the party with the asserts but I see them as very valuable checks, particularly in a library like ours. Sometimes we *do* want to enforce...