Jmlundeen
Jmlundeen
I think this is now ready for critique, face down cards more accurately represent game state. example showing visibility on gaining control with bane alley broker, owner cannot see their...
Ooops, yeah should have took it out of draft. I'll take a look at the issues to confirm which can be closed.
* https://github.com/magefree/mage/issues/12480 Just the face down part of this issue is handled. visibility should carry between exiled zones. * https://github.com/magefree/mage/issues/3583 -- fixed * https://github.com/magefree/mage/issues/13431 -- needs research, could be added...
Yup, that will be fixed as well
It's bee awhile since I've touched this one, I should go through it again
I can see splitting to `getAffectedObjects` and `applyToObjects` working and could revert dependency changes to turn this branch/PR into reworking to affected objects logic first. This split approach will help...
Gotcha, I misunderstood what you were saying. You wanted the queryObjects and applyToObjects to be inside of the apply methods? I don't think these are necessary for `applies` since those...
@JayDi85 is this current implementation more appropriate?
@JayDi85 OK, I did some more tweaking. The only thing I'm not completely sold on is `discard()` location for the single layer effects. Since those don't really need to implement...
Both styles are currently supported and I'm making sure to run the tests as well. Most of these changes are small as well. I'll just hold off on pushing more...