rework-face-down-cards

[Jmlundeen]

This changes face-down cards to only reveal information to players who have been allowed to see the cards instead of giving the controller access

fixes #3583, fixes #11881, fixes #12610, fixes #11896, fixes #12161, fixes #6967, fixes #8109, fixes #11191, fixes #10800, fixes #11752, fixes #12163, fixes #12880, fixes #12882, fixes #13543

[Jmlundeen]

I think this is now ready for critique, face down cards more accurately represent game state.

example showing visibility on gaining control with bane alley broker, owner cannot see their card in exile (gonti), and no visibility for either player (pyxis)

example showing Ixidron flipping, ignoring transform permanents and mdfc, copying morph face down gives flip ability, and face down copies don't retain their copied abilities

[JayDi85]

1. Check issue with lookAt problems — are there related fixes in current PR?
   • https://github.com/magefree/mage/issues/12480
2. Check face down info issues — what can be closed in current PR?:
   • https://github.com/magefree/mage/issues/13431
   • https://github.com/magefree/mage/issues/11881
   • https://github.com/magefree/mage/issues/12159
   • https://github.com/magefree/mage/issues/11881
   • https://github.com/magefree/mage/issues/12160
   • https://github.com/magefree/mage/issues/11896
3. Make sure game logs compatible with face down too (no info discloses, no errors/popups on mouse over, etc)

P.S. Some issues can be outdated due new face down “look at” logic in current PR — that’s ok

[JayDi85]

4. It’s in draft state — are you planning to add more changes in current PR?

[Jmlundeen]

Ooops, yeah should have took it out of draft. I'll take a look at the issues to confirm which can be closed.

[Jmlundeen]

• https://github.com/magefree/mage/issues/12480 Just the face down part of this issue is handled. visibility should carry between exiled zones.
• https://github.com/magefree/mage/issues/3583 -- fixed
• https://github.com/magefree/mage/issues/13431 -- needs research, could be added to this PR
• https://github.com/magefree/mage/issues/11881 -- fixed
• https://github.com/magefree/mage/issues/12014 -- need more research
• https://github.com/magefree/mage/issues/12159 -- needs more work outside of exile
• https://github.com/magefree/mage/issues/12160 -- fixed
• https://github.com/magefree/mage/issues/11896 -- fixed
• https://github.com/magefree/mage/issues/12161 -- fixed
• https://github.com/magefree/mage/issues/6967 -- fixed
• https://github.com/magefree/mage/issues/8109 -- fixed
• https://github.com/magefree/mage/issues/11191 -- fixed
• https://github.com/magefree/mage/issues/10800 -- fixed
• https://github.com/magefree/mage/issues/8793 A 2/2 empty creature is created but still issue with a face-down copy. A token of the copied card is created.

[JayDi85]

@Jmlundeen can you check new issue with Yedora, Grave Gardener #13543 and add it to the list (if it was fixed here)?

[Jmlundeen]

Yup, that will be fixed as well

[PurpleCrowbar]

How's this looking? This is likely one of the most important PRs in recent memory based on sheer quantity of bugs it fixes for many very broken cards so should probably be merged before the next release.

[JayDi85]

It's need code review. I'll do it later

[PurpleCrowbar]

Any word on this? Would be good to have all of these issues closed before the next release

[xenohedron]

@JayDi85 this PR really should not be languishing for so long, it's an important improvement to fix many bugs. If you don't review soon I will.

[JayDi85]

@xenohedron feel free to review any PRs - it will help anyway. Current PR require deep research in gui related changes with card views, hints and images.

[Jmlundeen]

It's bee awhile since I've touched this one, I should go through it again