JiaKe
JiaKe
@majetideepak @xiaoxmeng @HuamengJiang Can you help to review this PR again? Thanks for your help.
@mbasmanova @majetideepak @xiaoxmeng @HuamengJiang @rui-mo Resolved all your comments. Can you help to review again? Thanks.
@rui-mo Thanks for your review. I have resolved all your comments. Can you help to review again? Thanks.
@xiaoxmeng I have updated this PR based on your suggestions. Can you help to review again? Thanks.
> @JkSelf the PR is depending on the Velox PR, right? @FelixYBW Yes. Pending https://github.com/facebookincubator/velox/pull/10446 and https://github.com/facebookincubator/velox/pull/9835
> Hi @JkSelf thanks for creating this! We seem to be getting this error when trying to build on latest main after patching the change, just wanted to know if...
@pedroerp The ci is passed. Can you help to review? Thanks.
@pedroerp Can you help to review this PR？ Thanks.
@pedroerp Sorry for the delay response. I have resolved all your comments. Can you help to review again? Thanks.
@mbasmanova @majetideepak Can you help to review? Thanks.