apache
Use jvm libhdfs replace c++ libhdfs3
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename commit message and pull request title in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Seems velox-hdfs part needs to be removed from vcpkg.json. And ports/libhdfs3 also needs to be removed.
@JkSelf the PR is depending on the Velox PR, right?
@FelixYBW Yes. Pending https://github.com/facebookincubator/velox/pull/10446 and https://github.com/facebookincubator/velox/pull/9835
Hi @JkSelf thanks for creating this! We seem to be getting this error when trying to build on latest main after patching the change, just wanted to know if any additional changes should be made? Thanks!
CMake Error at velox/CMakeLists.txt:96 (message):
Library does not exist:
/home/user/gluten/ep/build-velox/build/velox_ep/_build/release/lib/libvelox.a
Call Stack (most recent call first):
velox/CMakeLists.txt:242 (import_library)
-- Configuring incomplete, errors occurred!
Hi @JkSelf thanks for creating this! We seem to be getting this error when trying to build on latest main after patching the change, just wanted to know if any additional changes should be made? Thanks!
CMake Error at velox/CMakeLists.txt:96 (message): Library does not exist: /home/user/gluten/ep/build-velox/build/velox_ep/_build/release/lib/libvelox.a Call Stack (most recent call first): velox/CMakeLists.txt:242 (import_library) -- Configuring incomplete, errors occurred!
Hi @ArnavBalyan, No additional changes are necessary. It appears that the Velox compilation has failed. Could you please confirm whether Velox has compiled successfully?
I see thanks, it seems to be failing silently somewhere before. The buildbundle stops here with the error. I can debug why velox did not build. Can you please point me to the cmake where the .so is being built. Will add some logs to see whats happening thanks!
