JiaKe
JiaKe
@xiaoxmeng Can you help to merge this PR? Thanks.
> @JkSelf : Can we have a test for this code specifically ? Would be great if you can add something. @aditi-pandit The existing unit tests [here ](https://github.com/facebookincubator/velox/blob/main/velox/exec/tests/WindowTest.cpp#L128-L295)can verify this...
@aditi-pandit @FelixYBW Resolved all your comments. Can you help to review again? Thanks. I updated the pool capacity from 8MB to 4MB [here ](https://github.com/facebookincubator/velox/pull/11077/files#diff-9f41a5e1a8da742fc53f54ba85588678cdb81ffb05b38eefebe21ad5138def8eR183)and the oom will occur without this...
> > @aditi-pandit @FelixYBW Resolved all your comments. Can you help to review again? Thanks. I updated the pool capacity from 8MB to 4MB [here ](https://github.com/facebookincubator/velox/pull/11077/files#diff-9f41a5e1a8da742fc53f54ba85588678cdb81ffb05b38eefebe21ad5138def8eR183)and the oom will occur...
@xiaoxmeng @aditi-pandit @FelixYBW I attempted to increase the number of rows while reducing the memory capacity. However, this approach failed when creating the RowVector with lower memory capacity during unit...
@xiaoxmeng Resolved all your comments. Please help to review again. Thanks.
> Thanks @kou. The changes look great! I will run the TPC-H velox benchmarks over Parquet data just to ensure there is no perf regression. > > CC: @JkSelf, @rui-mo...
@majetideepak @kou @pedroerp I tried running the 1TB TPC-DS benchmark with this PR, but encountered the following exception: ``` Caused by: org.apache.gluten.exception.GlutenException: Exception: VeloxRuntimeError Error Source: RUNTIME Error Code: INVALID_STATE...
> I'm not familiar with Apache Hadoop but Apache Hadoop uses Apache Thrift in Java not C++, right? It seems that `libhdfs.so` https://github.com/apache/hadoop/tree/trunk/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs calls Java API instead of implement HDFS...
@kou I used a try-catch approach to locate the code that throws the exception. I found that the exception is triggered during the deserialization of the Thrift header [here](https://github.com/facebookincubator/velox/pull/14942/files#diff-58ef2bd79ff4173b5a384a3016d6f7bd7d4b237876251cc9d9910e162993eaaaR99-R103). The...