Jerry Shea comments

Results 62 comments of


                                            Jerry Shea

Resolved java.lang.UnsatisfiedLinkError on M1 mac with Zing

Currently the TeamCity mac build is not compiling. ``` [04:45:11] : [Step 1/3] javah -force -classpath ../../../target/classes -d ../../../target/classes/../jni software.chronicle.enterprise.internals.impl.NativeAffinity net.openhft.ticker.impl.JNIClock [04:45:11] : [Step 1/3] g++ -O3 -Wall -shared -fPIC...

fixed NumberFormatException when core 63 was used in -Daffinity.reserved

Thanks @m-anthony - could I suggest you add a test that would have failed with the old behaviour?

Review the fork with new features and merge as appropriate

@plusterkopp it looks like this has been forgotten. A number of enhancements have been made to this library since your fork. If there is still a use for this fork...

Increase test coverage for YamlWire

[62.6% coverage as of today](https://sonarcloud.io/code?id=OpenHFT_Chronicle-Wire&selected=OpenHFT_Chronicle-Wire%3Asrc%2Fmain%2Fjava%2Fnet%2Fopenhft%2Fchronicle%2Fwire%2FYamlWire.java)

Improved documentation and code cleanups

I can document some of this - will do tomorrow.

Improved documentation and code cleanups

Have added some javadoc although we need some better doco in the README

Issue a warning when final field is overwritten #414

> What should we do - should we update them all? > IMO yes we should - our code should set a good example

Persistent map file using custom marshaller is significantly larger than a using built-in one

@edudar is this still a relevant question for you?

The contract for EventHandler#loopFinished is violated a lot

We should check that loopStarted is also called in event loop thread too. The reason for the cleanup comment is for historical reasons - TcpEventHandler used to close its Bytes...

HashWire is non-binary (text) wire which leads to object allocation, CPU usage

I personally think it is OK to change the hash value now, in x.22