Jeremy Rand
Several of the methods in the data and dns plugins are returning a string (generated using json.dumps) instead of simply returning the JSON data itself. This seems completely unnecessary, and...
We should make sure that our code is PEP 8 compliant, particularly before many people are relying on noncompliant aspects of the current codebase. https://www.python.org/dev/peps/pep-0008/ ## --- Want to back...
Right now, debug mode will output a lot of private data (e.g. domains being looked up). We should clearly warn the user of this if debug mode is enabled (both...
As discussed in https://github.com/namecoin/nmcontrol/pull/49 , the REST TLS code (not yet merged, but probably will be merged soon) supports old SSL/TLS versions and weak and non-forward-secret ciphersuites. I have some...
Namecoin Core gives this error when name_show is issued during syncup, so that the user doesn't unexpectedly get old data: ``` Namecoin is downloading blocks... (code -10) ``` Unfortunately NMControl...
The pLoadconfig method of plugins doesn't have access to all of the plugin's dependencies when the plugin first starts. This causes a nasty race condition where a plugin can fail...
The namecoind RPC interface in NMControl is an ugly hack. As far as I can tell it's violating the HTTP spec, and we're just lucky that it works at all....
The reload method should apply all changes from the config files; we should test it with all plugins to make sure that the new config file options actually take effect....
The current logging system is pretty inflexible, it doesn't show timestamps, only supports two verbosity levels, and doesn't directly support logging to a file. Python has a standard logging module,...
I believe this code works, except for the TLS code (which I'm leaving for later since TLS won't be in Bitcoin Core for much longer, and supporting TLS proxies is...