Jeremy Rand
Jeremy Rand
Sometimes donors will have special requirements (e.g. they may specifically want to be credited, or they may specifically *not* want to be credited). This PR clarifies that we are happy...
Refs https://github.com/namecoin/electrum-nmc/issues/292
Apply the changes discussed in https://github.com/namecoin/namecoin-core/issues/542 to Electrum-NMC as well.
Upstream Electrum has switched their Android GUI from Kivy to QML: https://github.com/spesmilo/electrum/tree/1880c6a74987ad602914a851c54f364c740e900b/electrum/gui/qml Coincidentally, upstream Bitcoin Core is doing experiments with switching their desktop GUI to QML as well: https://github.com/bitcoin-core/gui-qml/tree/e7bea2d9373764427878531b66e246c4ba94235f/src/qml It...
Upstream Bitcoin Core listens on two P2P ports: port 8333 (for IP connections) and port 8334 (for Tor onion service connections), as per this log from Bitcoin Core: ``` 2024-08-14T19:52:08Z...
With b3b7c95762b4bd80ec809bdcdf5a90ae4602f898, when an outgoing name transfer shows up, it incorrectly gets marked as a currency debit, via [this code path](https://github.com/namecoin/namecoin-core/blob/b3b7c95762b4bd80ec809bdcdf5a90ae4602f898/src/qt/transactionrecord.cpp#L184). It should get marked as a name transfer.
With b3b7c95762b4bd80ec809bdcdf5a90ae4602f898, when an incoming name transfer shows up, it appears as the following 3 rows: * 2x from [this code path](https://github.com/namecoin/namecoin-core/blob/b3b7c95762b4bd80ec809bdcdf5a90ae4602f898/src/qt/transactionrecord.cpp#L219-L221). Shows up as a name transfer (correct) but...
(Blocked by https://github.com/namecoin/electrum-nmc/issues/381 and upstream Bitcoin Core support for QML, but opening this issue anyway for tracking purposes.)
Per discussion with Ryan, we are going to special-case Punycode domains as `NXDOMAIN` in ncdns due to security concerns about homograph attacks. As such, the Namecoin-Qt wallet GUI should warn...
~~(Marked as WIP because it needs a rebase to fix some merge conflicts that accumulated while I was working on this PR. No need to concern yourself with this PR...