nmcontrol icon indicating copy to clipboard operation
nmcontrol copied to clipboard

Unnecessary json.dumps in data and dns plugins

Open JeremyRand opened this issue 10 years ago • 0 comments

Several of the methods in the data and dns plugins are returning a string (generated using json.dumps) instead of simply returning the JSON data itself. This seems completely unnecessary, and makes it more complicated for applications (or people!) to query NMControl. While fixing this will break existing client applications until they're patched (the patch is trivial), I think we should fix this sooner rather than later. (And I speak as the maintainer of at least two applications that will need patching.) Notably, data.getValueProcessed is doing this the correct way already.

If we can get an ACK on the desirability of fixing this, I'm happy to implement the fix.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10466864-unnecessary-json-dumps-in-data-and-dns-plugins?utm_campaign=plugin&utm_content=tracker%2F435873&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F435873&utm_medium=issues&utm_source=github).

JeremyRand avatar Apr 04 '15 14:04 JeremyRand