Jeremy Rand

Quite a few of the added lines have trailing whitespace. If you run `git diff fe2ff395aa25387f1acfefd1722b3e10f199d21e..b035e5ca2b382e46a946a55e1806e02e3bb0baf4`, it'll show a diff of your PR; trailing whitespace in the added lines will...

Tested b035e5ca2b382e46a946a55e1806e02e3bb0baf4, all functionality works fine for me. Just some small code style issues (see review above).

> Quite a few of the added lines have trailing whitespace. If you run `git diff fe2ff395aa25387f1acfefd1722b3e10f199d21e..b035e5ca2b382e46a946a55e1806e02e3bb0baf4`, it'll show a diff of your PR; trailing whitespace in the added lines...

ACK 558bad42a823057bc2716aa7d3265faed6fadfa6. Code review looks OK to me, unit tests pass, and manual testing of the GUI doesn't show any problems.

@domob1812 Feel free to merge.

Wow, blast from the past. A couple of these I had never even heard of (I guess they're from before I joined in 2013). This definitely shouldn't be ported to...

Feel free to comment on my evaluation; if no ACKs/NACKs are received within 1 week I will make the specified changes.

NamecoinToBind (which is referenced in the wiki article) has been replaced by ncdumpzone. However, ncdumpzone isn't mentioned on Namecoin.org. I guess we should add a mention before we close this...

@domob1812 Mind reviewing this?

That would be this line, yes? https://github.com/namecoin/namecoin-core/blob/a9942103e7d7662dfa4270198bd7910b38d9b446/src/qt/nametablemodel.cpp#L191 > Swapping `get_bool()` for `isTrue()` at `src/qt/nametablemodel.cpp:191` does make the symptom go away, for whatever that's worth. Will report back with outcomes of...