namecoin
Overhauled the Buy Names Page with the Electrum-NMC version
Overhauled the Buy Names Page with the Electrum-NMC version and added error boxes for invalid domain names.
OK so initial reaction: the XML form changes here are really hard to review because there's too much happening in a single commit. For example, the text Use <strong>d/</strong> prefix for domain names. shows up in both the old and new XML forms, but the diff is complicated enough that Git can't tell that those two lines correspond.
I think one way to improve this would be to split the XML form diff into two commits: one that exclusively tweaks whitespace on existing lines, and one that adds/removes lines. This should make it a lot easier for Git to tell which lines correspond in the diff.
I'd like @JeremyRand to review this, as he is the one who did the Qt code and I'm not really proficient with it.
Based on code review of 7c1b67d50567e974053ce0a4b0b5fcc818d1f8fd, only a few small issues (see review above). Also please change the commit message to something more descriptive.
I'll do a final round of testing in the next 24 hours but I'm not expecting to see any major problems there.
Should I fix the issues highlighted above now, or is it better if I wait for your final checks on the PR?
Should I fix the issues highlighted above now, or is it better if I wait for your final checks on the PR?
@junekomeiji Feel free to fix them now.
Quite a few of the added lines have trailing whitespace. If you run git diff fe2ff395aa25387f1acfefd1722b3e10f199d21e..b035e5ca2b382e46a946a55e1806e02e3bb0baf4, it'll show a diff of your PR; trailing whitespace in the added lines will be highlighted with a red background, which should make it easy for you to find and fix them.
Tested b035e5ca2b382e46a946a55e1806e02e3bb0baf4, all functionality works fine for me. Just some small code style issues (see review above).
Quite a few of the added lines have trailing whitespace. If you run
git diff fe2ff395aa25387f1acfefd1722b3e10f199d21e..b035e5ca2b382e46a946a55e1806e02e3bb0baf4, it'll show a diff of your PR; trailing whitespace in the added lines will be highlighted with a red background, which should make it easy for you to find and fix them.
There's still one in buynamespage.h
ACK 558bad42a823057bc2716aa7d3265faed6fadfa6. Code review looks OK to me, unit tests pass, and manual testing of the GUI doesn't show any problems.