Jeremy Rand
@phelixbtc I realize you can't test this since you're on Windows; should we merge this or wait for someone else to review?
@phelixbtc Good feedback, I'll make those changes and get back to you.
Upon talking to Hugo on IRC, I'm going to temporarily put this PR on hold. So don't merge at this time.
Agreed, we should do this. The question is what the period should be, and whether it should be variable based on the name owner's wishes. I don't think there was...
Thanks Ryan, I'll look at this shortly.
@phelixbtc , for legal reasons we are unable to accept unlicensed code. This has been discussed at length. I have already rewritten the relevant code, I will post it soon.
This is the "right" way to validate IP addresses, once we upgrade to Python3. https://docs.python.org/3/library/ipaddress.html
Generally, I'd like to use PEP 8 rather than mixedCase. We've already gotten a complaint from another developer about that. The sooner we change it, the less it will mess...
@phelixbtc do you have any objection if we use the PEP 8 variable/instance naming style? I really want to get that fixed before we start guaranteeing a stable API.
Fixed by https://github.com/namecoin/namecoin-core/pull/500. Please open a new issue if you still have connectivity issues.