Results 621 comments of Jeremy Rand

Note that if this PR is approved, it will be applied to ~~4.0.4~~ 4.0.6 (which branched after this PR was created), not 4.0.2.

Good review, thanks. > Amount comparison shouldn't be equality; if someone offers to buy my name for $100, selling it for $99 should be OK (as long as I get...

Merged to 4.0.6 branch per consensus with @yanmaani. Leaving this PR open to track subsequent improvements from his review.

@domob1812 What's your take on this suggestion? AFAICT using subclasses instead of editing the existing classes would reduce merge conflicts, but it would also increase the risk of us failing...

Blocked by https://github.com/spesmilo/electrum/issues/5430

> Blocked by [spesmilo#5430](https://github.com/spesmilo/electrum/issues/5430) Merged upstream, not sure if we've picked it up downstream yet.

Implementation-wise, seems like we could add a few lines to [get_spendable_coins](https://github.com/namecoin/electrum-nmc/blob/6781b550ef5cfc786a957c3df1649559c2f9305b/electrum_nmc/electrum/wallet.py#L627-L638). In particular, accepting an extra optional parameter `only_linkable_names`, and using that with the output of `listaddressgroupings` to filter `self.frozen_addresses`...

Anyone who wants to implement this, please contact me to coordinate. :)

> Currently there is no way to delete an expired name from the ManageNames tab, even it is already expired and registered by someone else. I'm leaning toward putting a...

> OS: Arch Linux Python: 3.10 > > Compiled tag v4.0.0b0 from source: > > ``` > $ for i in dnsdialog dnssubdomaindialog; do > pyuic5 electrum_nmc/electrum/gui/qt/forms/$i.ui --execute --output=electrum_nmc/electrum/gui/qt/forms/$i.py >...