Jeremy Rand
Jeremy Rand
@rllola Nice work, looking a lot better now. A few more minor tweaks: https://github.com/rllola/electrum/blob/549102e9442221672895ce877aeb658f3fc28f0c/debian/changelog#L5 A couple of stray space characters here. https://github.com/rllola/electrum/blob/549102e9442221672895ce877aeb658f3fc28f0c/debian/control#L31-L32 Add `Recommends` field between these two lines; can...
> > Maybe I'm missing something, but it looks like the latter half of this is redundant (since Electrum Team is specified in both halves). Also, is the copyright year...
@rllola Looking good. More feedback: https://github.com/rllola/electrum/blob/3de59091148b3af30b0709a494c882706851aa21/debian/copyright#L3 Please use `https://www.namecoin.org/download/betas/`; it appears that upstream doesn't use a Git repo for this line. https://github.com/rllola/electrum/blob/3de59091148b3af30b0709a494c882706851aa21/debian/copyright#L9 There's a missing newline here compared to upstream...
https://github.com/rllola/electrum/blob/36c86660df6c88b4c5aa6e4ebad4f3b459084ef7/debian/control#L73-L74 Since Electrum-NMC isn't Electrum, maybe this should be reworded to "Electrum-NMC is open source and is a fork of Electrum, which was first released in November 2011." > I...
> @rllola Do you want me to reach out to the Debian people about getting it added, or do you want to do that? @rllola If you want to reach...
@rllola I just did some QA testing of the package in a Debian Sid VM. In addition to the two minor issues I noted on April 8, two more minor...
@rllola So, I just realized that our source tarballs don't actually include `contrib/make_qt_forms`, thus we are violating Debian policy. I've filed https://github.com/namecoin/electrum-nmc/issues/292 to track that. Until that issue is fixed,...
@rllola How are things going on this? We haven't heard much from you for a little while. As this task is now somewhat behind schedule, @yanmaani and I will try...
@domob1812 Yes, I concur. What do you think is the best approach to writing the tests? Is it likely that we could copy the approximate logic of the Namecoin Core...
@gits7r Did you try on other OS's? When it failed on Windows, were you using a SOCKS proxy?